On Thu, 20 May 2004 21:30:32 -0700
Greg KH <[EMAIL PROTECTED]> wrote:
> > - if (!port->read_urb) {
> > + if ((serial->dev->descriptor.idVendor != SONY_VENDOR_ID && !port->read_urb))
> > + {
> Your patch says that we might not have a read_urb for the given port?
> How could that be true? The check here in open() will catch any devices
> that this might not be correct for. So that portion of this patch is
> not needed, right?
I know nothing about Palms, but also that part contradicted a comment.
- if (!port->read_urb) {
+ if ((serial->dev->descriptor.idVendor != SONY_VENDOR_ID && !port->read_urb))
+ {
/* this is needed for some brain dead Sony devices */
So.... the patch makes the body of the if to be used when it's NOT Sony,
but the comment says that it's intended for Sony. I think it's fishy.
-- Pete
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
