Hi,
you are doing in unaligned access in irq. This will increase latency on arches
which have a problem with that.
Regards
Oliver
Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]>
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-05-31 18:08:08+02:00, [EMAIL PROTECTED]
- unaligned memory access in irq
cdc-acm.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff -Nru a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
--- a/drivers/usb/class/cdc-acm.c Mon May 31 18:08:40 2004
+++ b/drivers/usb/class/cdc-acm.c Mon May 31 18:08:40 2004
@@ -60,6 +60,7 @@
#include <asm/uaccess.h>
#include <linux/usb.h>
#include <asm/byteorder.h>
+#include <asm/unaligned.h>
#include "cdc-acm.h"
@@ -108,7 +109,7 @@
{
struct acm *acm = urb->context;
struct usb_ctrlrequest *dr = urb->transfer_buffer;
- unsigned char *data = (unsigned char *)(dr + 1);
+ unsigned char *data;
int newctrl;
int status;
@@ -130,6 +131,7 @@
if (!ACM_READY(acm))
goto exit;
+ data = (unsigned char *)(dr + 1);
switch (dr->bRequest) {
case ACM_IRQ_NETWORK:
@@ -139,7 +141,7 @@
case ACM_IRQ_LINE_STATE:
- newctrl = le16_to_cpup((__u16 *) data);
+ newctrl = le16_to_cpu(get_unaligned((__u16 *) data));
if (acm->tty && !acm->clocal && (acm->ctrlin & ~newctrl &
ACM_CTRL_DCD)) {
dbg("calling hangup");
===================================================================
This BitKeeper patch contains the following changesets:
1.1764
## Wrapped with gzip_uu ##
M'XL( (A8NT \64;VO;,!#&[EMAIL PROTECTED];.EFV4W<NW=JRE0T6LO5U4&0E
M#O6?3I);"O[P4Q+(UFU-MC*8+1#6G1[?<_JA =P8I3.OK=;W2I,!O&^-S;Q:
MR(6R9="H[K:[EMAIL PROTECTED]:O7&C6MBX4EFVMPEU^^$4K94(K&''QJ;"R!+=L,@^#:+]B
M'^]4YLVNWMU\?#,C),_AHA3-2GU6%O*<V%;?BZHPY\*65=L$5HO&U,J*0+9U
MOT_M&:7,O3&F$8V3'A/[EMAIL PROTECTED]@XJH(R/DDXV15V_JN!ITJ<QA%BS")&^YA/
M)B?D$C# -.% >4CC,$+ 248W8TQ91BD\JPQC!)^2M_!OG5P0"3YTC:C6JT85
[EMAIL PROTECTED]&P+J!M?Y*/D#,3RB2Z?>>$O\O'T*HH.3L2/[EMAIL PROTECTED]<6H9!U
M('^PP2FF?9RD)TF_D%&\1%PR'BTCE2Z>;]L315D)8T)92'^OO3NBA$XH.NTH
M3K?H'-AT'*87>C@ U1]Y<)@AZV.&+-EB]AO(\#AD''SVWR#;]O\3^/IA.QPT
MTT-'\0(&KQ,&2 ;K1E9=H>"U,'[EMAIL PROTECTED]>87<FR%!I>%<**
M4Q>,-BK>[EMAIL PROTECTED]&/Z4-!H6&L: HU.GQME6;3MYGM>H!VEUY795"I.Y;>?RKANN
IE)[EMAIL PROTECTED],.$Z<#FQ^,G,S^DI.EDK>FJW.AJ$R%6)!O"7]:ZEL%
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
