Greg KH wrote:
On Thu, Jun 03, 2004 at 12:43:31PM -0400, nardelli wrote:
I'm looking into possible memory leaks in the visor driver,
and I had a question regarding behavior of error handling on
failed urb submission. From what I understand, when
submitting a urb fails, the completion handler will not be
called (as indicated in the api). It would appear that
this case is not handled properly in visor_write when this
happens though. I would imagine that kfree() should be called
for buffer when a non-zero status is returned by
usb_submit_urb(). Am I missing something?
Nope, you are correct. Care to send in patches to fix this up?
thanks,
greg k-h
Sure. After a quick look, it appears that the only other driver
with this present is ftdi_sio (for some reason I thought it was
more).
--
Joe Nardelli
[EMAIL PROTECTED]
-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
