Note that I have not verified any of the below on hardware associated with drivers/usb/serial/ftdi_sio.c, only with drivers/usb/serial/visor.c. If anyone has hardware for this device, I would appreciate your comments.
A memory leak occurs in both drivers/usb/serial/ftdi_sio.c and drivers/usb/serial/visor.c when the usb device is unplugged while data is being written to the device. This patch should clear that up.
The change to ftdi_sio.c looks correct to me.
I made the original change to ftdi_sio.c to allocate the write urbs and their transfer buffers dynamically (instead of using a preallocated pool) and I copied that technique from visor.c!
A related problem with the current implementation is that is easy to run out of memory by running something similar to this:
# cat /dev/zero > /dev/ttyUSB0
That affects both the ftdi_sio and visor drivers.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <[EMAIL PROTECTED]> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
