On Sun, Jun 13, 2004 at 10:21:49AM -0700, Matthew Dharm wrote: > Try this version on for size. Lots of help-text changes, but also a key > change in how the CONFIG option is processed. I think the last version I > sent was logically inverted from what we described. > > Matt > > > ===== drivers/usb/storage/Kconfig 1.12 vs edited ===== > --- 1.12/drivers/usb/storage/Kconfig Wed Mar 17 11:16:51 2004 > +++ edited/drivers/usb/storage/Kconfig Sun Jun 13 10:13:41 2004 > @@ -23,6 +23,25 @@ > Say Y here in order to have the USB Mass Storage code generate > verbose debugging messages. > > +config USB_STORAGE_RW_DETECT > + bool "USB Mass Storage Write-Protect Media Detection (EXPERIMENTAL)" > + depends on USB_STORAGE && EXPERIMENTAL > + help > + Say Y here in order to have the USB Mass Storage code indicate to > + the SCSI layers that using MODE SENSE(6) and MODE SENSE(10) to > + determine if the media is write-protected is a good thing to do. > + > + Many devices have historically had trouble with these commands, > + hence the default 2.6.x behavior has been to supress their use. > + 2.4.x used this commands with (at best) mixed results, often > + crashing the firmware of the device. > + > + Recent changes to the SCSI layer now make use of these commands > + in a manor which is more consistent with other "popular" OSes, in > + an attempt to improve compatibility.
Typos: manor -> manner, supress -> suppress General comment: It is a really bad idea to introduce such configuration options. For many reasons: First of all, introducing options is always bad. We do not need ten thousand configuration options. Secondly, introducing options is always bad. The user has no idea what to answer. She doesn't know anything about usb-storage or SCSI, and certainly nothing about how her memory stick reader will react to MODE SENSE(6) commands. Thus, she will try one choice, and if it fails the other choice. In case of N binary options the user will try blindly and without understanding 2^N combinations to see whether one works. Bad. Thirdly, introducing options is bad. The distribution provider does not know anything about the user's devices. How must he choose the options? Fourthly, introducing options is bad. The user may have several devices, where these devices need different answers to this question. We need code that works, and if we are unable to write such code, code that can be made to work by using dynamic settings. Andries ------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X. >From Windows to Linux, servers to mobile, InstallShield X is the one installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
