On Sat, Jun 19, 2004 at 04:36:01PM +0200, Oliver Neukum wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> I overlooked that setting control lines in open can fail.
>
> Regards
> Oliver
>
> Signed-Off-By: Oliver Neukum <[EMAIL PROTECTED]>
Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]>
Greg, please, apply this one as well.
>
> You can import this changeset into BK by piping this whole message to:
> '| bk receive [path to repository]' or apply the patch as usual.
>
> ===================================================================
>
>
> [EMAIL PROTECTED], 2004-06-19 14:36:02+02:00, [EMAIL PROTECTED]
> - check for error doing control transfers
>
>
> cdc-acm.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> - --- a/drivers/usb/class/cdc-acm.c Sat Jun 19 14:37:06 2004
> +++ b/drivers/usb/class/cdc-acm.c Sat Jun 19 14:37:06 2004
> @@ -293,7 +293,8 @@
> goto bail_out_and_unlink;
> }
>
> - - acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS);
> + if (0 > acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS))
> + goto full_bailout;
>
> /* force low_latency on so that our tty_push actually forces the data through,
> otherwise it is scheduled, and with high data rates data can get lost. */
> @@ -304,6 +305,8 @@
> up(&open_sem);
> return 0;
>
> +full_bailout:
> + usb_unlink_urb(acm->readurb);
> bail_out_and_unlink:
> usb_unlink_urb(acm->ctrlurb);
> bail_out:
>
> ===================================================================
>
>
> This BitKeeper patch contains the following changesets:
> 1.1861
> ## Wrapped with gzip_uu ##
>
>
> begin 664 bkpatch6417
> M'XL(`'(SU$```\54T6Z;,!1]QE]QI;[EMAIL PROTECTED];@`E4B=HETU:MTR*:/B/'F`25
> MX,E`MTE\_`R9DD::TJZ:-(Q`]]H^U^?<(U_`0RUU;*FR>)(:7<`G53<FE)6J
> MI+-5.UD65?O#47IC)A.ES*3;[EMAIL PROTECTED]"Y:\$5LP2'5L$<<[
> M9)J?WV1L)1\^/MS=)`A-IS#?\FHC[V4#TREJE'[B959?\V9;JLII-*_JG6RX
> M(]2N.RSM*,;4C("$'@Y81QCVPTZ0C!#N$YEAZD^8C_9<KO_$X13+QXQ$A.`P
> M\#M_0L(`+8`X9,((8-_%S"41$#_V6(SI):8QQG`&&RX)V!B]AW_+9HX$V""V
> M4CQ"KC1(K<TW4T6U`:&[EMAIL PROTECTED]@M'R*#"R__)!"'.,9B_PR'2O
> M1.VV];KOOR.>\?$Q";N`A1'KUL(+<D)RZGNY)\/U.05/,$7)Z]H5F;`/Z/M^
> M42_P:$<BRL+!26<VO>RM-[(XZ[%7L<!!A$W/Z832P77,._5<$'NO\IP/-OGO
> MGMLWXRO8^OOP&@\MS_7E#99<T(@!0;?]CR*KR&&$808&+JUED_X^U<C$[_JD
> M/1.-+E5KKA>XF7])YZOD+EVL$NB.8;*Z'X^196U4HR!ORS)=\Z+?<X5N/=R7
> M>9Z,D668I&UEQ'],6[T>#66TY)D)QE?'ZV_0K6YWTR`+PTG`)?H%#^TEL68%
> "````
> `
> end
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFA1E9XbuJ1a+1Sn8oRAgWrAKDTWG4ZXiIKceqtevyMoUTMUAmBlQCeOgUd
> jYezZWQGXu8m77bRP/ntL2M=
> =dJk0
> -----END PGP SIGNATURE-----
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
