On Thu, 24 Jun 2004, Herbert Xu wrote: > Alan Stern <[EMAIL PROTECTED]> wrote: > > > > ===== drivers/usb/host/uhci-hcd.c 1.115 vs edited ===== > > --- 1.115/drivers/usb/host/uhci-hcd.c Wed Jun 23 12:10:07 2004 > > +++ edited/drivers/usb/host/uhci-hcd.c Wed Jun 23 12:30:05 2004 > > @@ -2261,6 +2261,11 @@ > > uhci->fl->frame[i] = cpu_to_le32(uhci->skelqh[irq]->dma_handle); > > } > > > > + /* > > + * Some architectures require a full mb() to enforce completion of > > + * the memory writes above before the I/O transfers in start_hc(). > > + */ > > + mb(); > > start_hc(uhci); > > > > init_stall_timer(hcd); > > Any reason why a wmb() is not sufficient?
See http://marc.theaimsgroup.com/?l=linux-usb-devel&m=108759528909973&w=2 > BTW it could just be my mailer but can you please check whether > you've got tabs in there instead of spaces? It must be your mailer, because the mail message (as retrieved from MARC) contains tabs. Alan Stern ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
