Pulling the usb tree is always fun.
drivers/bluetooth/bfusb.c: In function `bfusb_load_firmware': drivers/bluetooth/bfusb.c:589: structure has no member named `halted' drivers/bluetooth/bfusb.c:589: structure has no member named `halted' drivers/bluetooth/bfusb.c:631: structure has no member named `halted' drivers/bluetooth/bfusb.c:631: structure has no member named `halted'
Right, "halted" is gone, and won't be back. It was state that couldn't be accurate; the truth is kept in the device. I'd do the obvious make-it-compile fix for the moment.
That firmware loading code needs to be modified for other reasons. It shouldn't touch "toggle"; directly setting the configuration is dangerous; and it should probably just reset the device (that should now work!) to force re-enumeration after everything is updated ... since the old device state won't be cleaned up properly otherwise.
- Dave
Linus's tree has this diff:
Index: drivers/bluetooth/bfusb.c
===================================================================
RCS file: /opt/cvs/lk/drivers/bluetooth/bfusb.c,v
retrieving revision 1.6
diff -u -r1.6 bfusb.c
--- drivers/bluetooth/bfusb.c 23 May 2004 08:26:30 -0000 1.6
+++ drivers/bluetooth/bfusb.c 9 Jul 2004 00:33:55 -0000
@@ -585,6 +585,9 @@
return -EBUSY;
}
+ bfusb->udev->toggle[0] = bfusb->udev->toggle[1] = 0;
+ bfusb->udev->halted[0] = bfusb->udev->halted[1] = 0;
+
buf = kmalloc(BFUSB_MAX_BLOCK_SIZE + 3, GFP_ATOMIC);
if (!buf) {
BT_ERR("Can't allocate memory chunk for firmware");
@@ -623,6 +626,9 @@
BT_ERR("Can't change to running configuration");
goto error;
}
+
+ bfusb->udev->toggle[0] = bfusb->udev->toggle[1] = 0;
+ bfusb->udev->halted[0] = bfusb->udev->halted[1] = 0;
BT_INFO("BlueFRITZ! USB device ready");
But Greg's tree deletes usb_device.halted.
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
