On Thu, Jul 08, 2004 at 10:39:24PM -0700, Pete Zaitcev wrote:
> On Wed, 7 Jul 2004 17:52:01 -0400
> Adam Kropelin <[EMAIL PROTECTED]> wrote:
>
> > /* hiddev_usage_ref_multi is used for sending multiple bytes to a control.
> > * It really manifests itself as setting the value of consecutive usages */
> > +#define HID_MAX_MULTI_USAGES 1024
> > struct hiddev_usage_ref_multi {
> > struct hiddev_usage_ref uref;
> > __u32 num_values;
> > - __s32 values[HID_MAX_USAGES];
> > + __s32 values[HID_MAX_MULTI_USAGES];
> > };
>
> Woa dude, this is some enormous struct here. I sure hope we do not
> leave it included into some other struct accidentially.It is even worse - this monster thing is allocated on the kernel stack in hiddev_ioctl() :(
pgpsZ92IlxIrl.pgp
Description: PGP signature
