On Tue, 13 Jul 2004 20:57:14 +0200
Oliver Neukum <[EMAIL PROTECTED]> wrote:

> Am Dienstag, 13. Juli 2004 19:57 schrieb Nishanth Aravamudan:

> > In continuing to replace, where appropriate, code with msleep() calls, I 
> > ran across the following file(s) / function(s), which do not invoke 
> > set_current_state() before schedule_timeout(), which causes the latter 
> > to return immediately:
> > 
> > drivers/usb/misc/tiglusb.c::tiglusb_open()
> 
> TASK_INTERRUPTIBLE

In this case, Oliver is right. However, do not use TASK_INTERRUPTIBLE
in any path which is called from ->release(). When an application is
killed with ^C and is exiting, schedule() returns immediately if
called so, so the end result would be a fix with no effect.

-- Pete


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to