On Mon, Aug 16, 2004 at 11:22:13AM -0400, Alan Stern wrote: > On Mon, 16 Aug 2004, Norbert Preining wrote: > > > Hi ALan! > > > > On Fre, 13 Aug 2004, Alan Stern wrote: > > > In the meantime, you can try out this patch and see if it helps at all. > > > > Yup, fixed the problem. Thanks. > > > > One more question: > > > > > @@ -1654,7 +1654,8 @@ > > > usb_fill_int_urb(hid->urbout, dev, pipe, hid->outbuf, 0, > > > hid_irq_out, hid, interval); > > > hid->urbout->transfer_dma = hid->outbuf_dma; > > > - hid->urbout->transfer_flags |= URB_NO_TRANSFER_DMA_MAP; > > > + hid->urbout->transfer_flags |= (URB_ASYNC_UNLINK | > > > + URB_NO_TRANSFER_DMA_MAP); > > > } > > > } > > > > > > I have NO idea about usb programming, but there is a similar line a bit > > above for > > hid->urbin->transfer_flags > > and I wanted to ask wether there should be a URB_ASYNC_UNLINK there, > > too? > > I don't know. Someone who is more familiar with the HID driver (like > Vojtech) will have to answer. All I did was change the parts that were > obviously wrong, but there could easily be other things that are > non-obviously wrong.
Your patch is OK, the above is also fine, and keeping the RUNNING bits correct is rather trivial, too (just clear them on submit error). I've done all those changes to my tree, and I'll send you the complete patch tomorrow morning to test. -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
