Am Freitag, 27. August 2004 17:33 schrieb Greg KH:
> On Fri, Aug 27, 2004 at 10:40:35AM +0200, Oliver Neukum wrote:
> > Am Freitag, 27. August 2004 01:54 schrieb Greg KH:
> > > ChangeSet 1.1843.4.18, 2004/08/24 12:08:00-07:00, [EMAIL PROTECTED]
> > >
> > > USB: fix bad value in kaweth.c driver
> > >
> > > Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
> > >
> > >
> > > drivers/usb/net/kaweth.c | 2 +-
> > > 1 files changed, 1 insertion(+), 1 deletion(-)
> > >
> > >
> > > diff -Nru a/drivers/usb/net/kaweth.c b/drivers/usb/net/kaweth.c
> > > --- a/drivers/usb/net/kaweth.c 2004-08-26 16:42:08 -07:00
> > > +++ b/drivers/usb/net/kaweth.c 2004-08-26 16:42:08 -07:00
> > > @@ -668,7 +668,7 @@
> > > INTBUFFERSIZE,
> > > int_callback,
> > > kaweth,
> > > - HZ/4);
> > > + 8);
> > > kaweth->irq_urb->transfer_dma = kaweth->intbufferhandle;
> > > kaweth->irq_urb->transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
> >
> > Greg,
> >
> > could you please tell me where the patch has come from and what bug
> > it is to fix?
>
> I wrote it. Run sparse on the original and tell me what it says :)
[EMAIL PROTECTED]:/home/olli2/Trees/linus26> make C=1 drivers/usb/net/kaweth.o
CHECK drivers/usb/net/kaweth.c
include/linux/usb.h:892:21: warning: shift too big for type (40)
CC [M] drivers/usb/net/kaweth.o
> That field can't handle such a big number, so I just guesed as to what
> you really ment it to be. Have a better suggestion?
Yes. Revert it. Sparse here has overreached the limit of its usefullness.
The device is always full speed, never high speed. The shift won't be used.
The value is what the vendor recommends.
Regards
Oliver
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
