Make code more readable with list_for_each_entry.
Compile tested.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
Patch incremental on the list_for_each() change.
Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]>
---
linux-2.6.9-rc1-bk7-max/drivers/usb/core/devices.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff -puN drivers/usb/core/devices.c~list-for-each-entry-drivers_usb_core_devices
drivers/usb/core/devices.c
---
linux-2.6.9-rc1-bk7/drivers/usb/core/devices.c~list-for-each-entry-drivers_usb_core_devices
2004-09-01 19:34:25.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/usb/core/devices.c 2004-09-01 19:34:25.000000000
+0200
@@ -569,7 +569,6 @@ static ssize_t usb_device_dump(char __us
static ssize_t usb_device_read(struct file *file, char __user *buf, size_t nbytes,
loff_t *ppos)
{
- struct list_head *buslist;
struct usb_bus *bus;
ssize_t ret, total_written = 0;
loff_t skip_bytes = *ppos;
@@ -581,12 +580,9 @@ static ssize_t usb_device_read(struct fi
if (!access_ok(VERIFY_WRITE, buf, nbytes))
return -EFAULT;
- /* enumerate busses */
down (&usb_bus_list_lock);
- list_for_each(buslist, &usb_bus_list) {
- /* print devices for this bus */
- bus = list_entry(buslist, struct usb_bus, bus_list);
-
+ /* print devices for all busses */
+ list_for_each_entry(bus, &usb_bus_list, bus_list) {
/* recurse through all children of the root hub */
if (!bus->root_hub)
continue;
_
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
