Reuben:
The two patches below should eliminate the warning messages you see.
On Thu, 9 Sep 2004, Reuben Farrelly wrote:
> Hi,
>
> I have experienced a couple of traces in usblp.c and also with the uba
> device, in 2.6.9-rc1-mm4. These did not appear in -mm3:
>
> Sep 9 20:43:00 tornado kernel: usb 1-7: new high speed USB device using
> address 3
> Sep 9 20:43:00 tornado kernel: ub: sizeof ub_scsi_cmd 60 ub_dev 940
> Sep 9 20:43:00 tornado kernel: usb_unlink_urb() is deprecated for
> synchronous unlinks. Use usb_kill_urb()
> Sep 9 20:43:00 tornado kernel: Badness in usb_unlink_urb at
> drivers/usb/core/urb.c:456
> Sep 9 20:43:00 tornado kernel: [<c0297ca5>] usb_unlink_urb+0x6c/0x89
> Sep 9 20:43:00 tornado kernel: [<e0ccd7f3>]
> ub_probe_clear_stall+0x150/0x17e [ub]
Pete, it looks like time has caught up with you. Maybe you will want to
apply this patch:
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
===== drivers/block/ub.c 1.3 vs edited =====
--- 1.3/drivers/block/ub.c Fri Aug 27 15:24:25 2004
+++ edited/drivers/block/ub.c Thu Sep 9 14:00:01 2004
@@ -1748,10 +1748,12 @@
del_timer_sync(&timer);
/*
* Most of the time, URB was done and dev set to NULL, and so
- * the unlink bounces out with ENODEV. We do not call usb_kill_urb
- * because we still think about a backport to 2.4.
+ * the unlink bounces out with ENODEV.
+ *
+ * For 2.6 we need to call usb_kill_urb(). A backport to 2.4
+ * would require this to call usb_unlink_urb() instead.
*/
- usb_unlink_urb(&sc->work_urb);
+ usb_kill_urb(&sc->work_urb);
/* reset the endpoint toggle */
usb_settoggle(sc->dev, endp, usb_pipeout(sc->last_pipe), 0);
> Also this one:
>
> Starting cups: usb_unlink_urb() is deprecated for synchronous unlinks. Use
> usb)
> Badness in usb_unlink_urb at drivers/usb/core/urb.c:456
> [<c0297ca5>] usb_unlink_urb+0x6c/0x89
> [<c02a8479>] usblp_unlink_urbs+0xb/0x1f
Vojtech, it looks like usblp.c also needs to be changed:
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
===== drivers/usb/class/usblp.c 1.107 vs edited =====
--- 1.107/drivers/usb/class/usblp.c Tue Aug 24 10:55:34 2004
+++ edited/drivers/usb/class/usblp.c Thu Sep 9 13:55:56 2004
@@ -410,9 +410,9 @@
static void usblp_unlink_urbs(struct usblp *usblp)
{
- usb_unlink_urb(usblp->writeurb);
+ usb_kill_urb(usblp->writeurb);
if (usblp->bidir)
- usb_unlink_urb(usblp->readurb);
+ usb_kill_urb(usblp->readurb);
}
static int usblp_release(struct inode *inode, struct file *file)
-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
