On Tue, Sep 28, 2004 at 06:55:15AM -0700, David Brownell wrote:
> On Monday 27 September 2004 3:20 pm, Russell King wrote:
> > This driver doesn't appear to build as a module in current 2.6 kernel
> > sources, namely because it references usb_kill_urb_queue which isn't
> > exported.
> >
> > What would be the correct way to fix this?
>
> There's a new SL-811 driver from Lothar Wassmann which looks
> like the way to go. It reuses the OHCI core. So far as I know, the
> existing SL-811 code never worked on 2.6 kernels ...
If this is the one which provides the following files:
ohci-emu.c
ohci-sl811.c
ohci-sl811.h
then there's a number of issues here:
1. the existing SL811 driver looks a hell of a lot cleaner than this,
and doesn't end up abusing kernel infrastructure. One major example
of this is using bus_to_virt() to get the virtual address of a DMA
mapped address, and then reading/writing this directly.
2. It's already proven to be nonfunctional as it currently stands in
multiple ways, and I suspect it all comes from the way it abuses
kernel interfaces. Problems so far seen involve completely locking
up the kernel by spinning in root_port_reset() to being unable to
assign addresses to any devices.
3. It appears to contain a claim that ohci-sl811.c is written by
Christoper Hoover. I've been in touch with Christoper, who says
he has had nothing to do with the file. Since the file header is
identical except for one line ("SL811" instead of "SA1111") to
another file, I suspect that whoever wrote the thing has decided
to remain anonymous, and by doing so is apparantly passing the
driver off as someone elses work. Obviously there's legal
implications are rather interesting once such a work is published.
So, all in all, I'd like to get the existing SL811 driver to a
_runnable_ state to evaluate whether it performs any better than
this other seemingly dodgy ohci-emulating driver.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
