Hi. First, I want to say 'Thanks very much' to you (Lothar Wassmann) for your work on the ohci emulation for the SL811 chip and the ISP1362. I'm trying to use the ISP1362 with these new drivers at the moment, and they look good to my eyes.
I've got a couple comments and questions: 1. The ohci-isp1362.tgz files won't work without the ohci-emu patch. Should these be bundled together? (note: ohci-regs.h is added by both) 2. I downloaded the latest version of these drivers from http://www.karo-electronics.de/132.0.html. Can you add some sort of timestamp to it? (e.g. ochi-isp1362_1007.tgz) It would be nice to know when it has last been updated. 3. In drivers/usb/Kconfig: config USB tristate "Support for Host-side USB" depends on PCI || SA1111 || ARCH_OMAP1510 || ARCH_OMAP1610 || ARCH_LH7A404 || ARCH_KARO || MACH_OSCAR It would be nice to fix this. I wouldn't want to have to patch this file anytime someone has a machine that uses a USB controller. Have any ideas? (maybe take out all dependencies?) 4. I'm applying this patch to kernel 2.6.9-rc2. This is the relevant section from the patch ohci-emu.patch: ( this patch can be seen at http://lists.arm.linux.org.uk/pipermail/linux-arm-kernel/2004-September/024417.html ) (Please forgive the messed up formatting) @@ -533,18 +539,15 @@ wIndex--; switch (wValue) { case USB_PORT_FEAT_SUSPEND: - writel (RH_PS_PSS, - &ohci->regs->roothub.portstatus [wIndex]); + ohci_write_roothub_portstatus(ohci, wIndex, RH_PS_PSS); break; case USB_PORT_FEAT_POWER: - writel (RH_PS_PPS, - &ohci->regs->roothub.portstatus [wIndex]); + ohci_write_roothub_portstatus(ohci, wIndex, RH_PS_PPS); break; case USB_PORT_FEAT_RESET: - temp = ohci_readl (&ohci->regs->roothub.portstatus [wIndex]); + temp = roothub_portstatus(ohci, wIndex); if (temp & RH_PS_CCS) - writel (RH_PS_PRS, - &ohci->regs->roothub.portstatus [wIndex]); + ohci_write_roothub_portstatus(ohci, wIndex, RH_PS_PRS); break; default: goto error; This is what the code looks like for 2.6.9-rc2: switch (wValue) { case USB_PORT_FEAT_ENABLE: temp = RH_PS_CCS; break; case USB_PORT_FEAT_C_ENABLE: temp = RH_PS_PESC; break; case USB_PORT_FEAT_SUSPEND: temp = RH_PS_POCI; if ((ohci->hc_control & OHCI_CTRL_HCFS) != OHCI_USB_OPER) schedule_work (&ohci->rh_resume); break; case USB_PORT_FEAT_C_SUSPEND: temp = RH_PS_PSSC; break; case USB_PORT_FEAT_POWER: temp = RH_PS_LSDA; break; case USB_PORT_FEAT_C_CONNECTION: temp = RH_PS_CSC; break; case USB_PORT_FEAT_C_OVER_CURRENT: temp = RH_PS_OCIC; break; case USB_PORT_FEAT_C_RESET: temp = RH_PS_PRSC; break; default: goto error; } ohci_write_roothub_portstatus(ohci, wIndex, temp); //roothub_portstatus(ohci, wIndex); break; Is this section of the patch unneeded for 2.6.9-rc2? Thanks! Mike ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
