ChangeSet 1.1832.55.12, 2004/09/03 13:28:34+02:00, [EMAIL PROTECTED]

[PATCH] USB: switching microtek to usb_kill_urb

Am Dienstag, 31. August 2004 17:41 schrieb Alan Stern:
> On Tue, 31 Aug 2004, Oliver Neukum wrote:
>
> Alan Stern
>
>
>
>
> > @@ -822,9 +822,8 @@
> >
> >     usb_set_intfdata(intf, NULL);
> >
> > +   usb_kill_urb(desc->urb);
> >     scsi_remove_host(desc->host);
> > -   usb_unlink_urb(desc->urb);
> > -   scsi_host_put(desc->host);
> >
> >     usb_free_urb(desc->urb);
> >     kfree(desc);
>
> I think you still need the scsi_host_put(), to account for the fact that
> scsi_host_alloc() sets the refcount to 1 initially.

Right you are. Greg, please also apply this one.

Signed-Off-By: Oliver Neukum <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 drivers/usb/image/microtek.c |    1 +
 1 files changed, 1 insertion(+)


diff -Nru a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
--- a/drivers/usb/image/microtek.c      2004-10-19 08:19:22 -07:00
+++ b/drivers/usb/image/microtek.c      2004-10-19 08:19:22 -07:00
@@ -825,6 +825,7 @@
        usb_kill_urb(desc->urb);
        scsi_remove_host(desc->host);
 
+       scsi_host_put(desc->host);
        usb_free_urb(desc->urb);
        kfree(desc);
 }



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to