ChangeSet 1.1832.55.20, 2004/09/03 13:33:20+02:00, [EMAIL PROTECTED]

[PATCH] usb/dabusb: insert set_current_state() before schedule_timeout()

After discussing this patch with Mark Hollomon, I think it is much safer
/ better to leave the conditional check within the while loop. This way
the mutex state is as expected and maintainability is not compromised.
The previous patch should not be applied.


Description: Inserts appropriate set_current_state() call so that
schedule_timeout() functions as expected.

Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
Signed-off-by: Maximilian Attems <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>


 drivers/usb/media/dabusb.c |    1 +
 1 files changed, 1 insertion(+)


diff -Nru a/drivers/usb/media/dabusb.c b/drivers/usb/media/dabusb.c
--- a/drivers/usb/media/dabusb.c        2004-10-19 08:18:41 -07:00
+++ b/drivers/usb/media/dabusb.c        2004-10-19 08:18:41 -07:00
@@ -598,6 +598,7 @@
                if (file->f_flags & O_NONBLOCK) {
                        return -EBUSY;
                }
+               set_current_state(TASK_INTERRUPTIBLE);
                schedule_timeout (HZ / 2);
 
                if (signal_pending (current)) {



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to