On Friday 29 October 2004 13:35, Alan Stern wrote:

> @@ -192,7 +192,6 @@
>  
>       /* memory lifecycle */
>       struct usb_hcd  *(*hcd_alloc) (void);
> -     void            (*hcd_free) (struct usb_hcd *hcd);
>  
>       /* manage i/o requests, device state */
>       int     (*urb_enqueue) (struct usb_hcd *hcd, struct urb *urb,

Could you add a comment there that the HCD is
now _required_ to return a pointer that usbcore
can pass to kfree?  Since that's a layering
violation (in anticipation of later changes to
make it not be one!), it's surprising ... and
in any case, the memory lifecycle is no longer
described just by the calls in this header!

- Dave


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to