Re: [linux-usb-devel] [PATCH as428] Hub driver: several bug fixes and simplifications

[Oliver Neukum]

Am Montag, 29. November 2004 19:07 schrieb Alan Stern:
> On Mon, 29 Nov 2004, Oliver Neukum wrote:
> 
> > Am Montag, 29. November 2004 18:20 schrieb Alan Stern:
> > +
> > +               /* don't allow the user to unbind the hub driver from
> > +                * a hub with children to manage */
> > +               for (i = 0; i < ps->dev->maxchild; ++i) {
> > +                       if (ps->dev->children[i])
> > +                               retval = -EBUSY;
> > +               }
> > +               if (retval)
> > +                       break;
> > +
> > 
> > Are you sure locking is sufficient here?
> 
> Yes.  This code executes with ps->dev locked, and the children[] array    
> isn't changed without holding the device lock.

OK, I see.

        Regards
                Oliver
HW¦j)b˛ĘhžĘ+yÖňN?Lúčvç-čťyšv'zË\jwbv·Ż‰ě,˘xnťÚŢvĘ!3ëˇŰś¶Çë˘jŢj[¬z»ŠÇ(˝ęđ†'!¦şąËl¶»ĄĘXŻzęm˘Ř^‡*^JÖ«¶·šv)ྦ!¶Úţščvç-‚čťz+fjv z»#˘ęçjW(›ůbžěn±·^˝éeŠËl˛‹«qç讧zÔčş{.nÇ+‰·®±ëazV¬µú+™řž•Ö­†Űił˙ĺŠËl˛‹«qç讧zßĺŠËlţX¬¶)ߣůbžěn±·^˝é