Matt:

This is a trivial change, but it helps at least one person.  It may help
others too -- but so far Jan is the only person to report back any test
results.  Increasing the delay from 100 to 110us won't hurt much, at any
rate.

Ultimately we will need to find some other way to specify which devices 
need the time delay and what the delay should be, since we know that one 
size doesn't fit all and some non-Genesys devices also need the delay.
For now this will have to do.

Alan Stern


On Mon, 13 Dec 2004, Jan De Luyck wrote:

> I'm currently using the drive with a udelay of 110, and it works without any 
> problems. The transfer speed is indeed higher than with the 200msec delay ;)



Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

===== drivers/usb/storage/transport.c 1.153 vs edited =====
--- 1.153/drivers/usb/storage/transport.c       2004-11-22 13:42:02 -05:00
+++ edited/drivers/usb/storage/transport.c      2004-12-15 16:25:40 -05:00
@@ -985,9 +985,10 @@
        /* send/receive data payload, if there is any */
 
        /* Genesys Logic interface chips need a 100us delay between the
-        * command phase and the data phase */
+        * command phase and the data phase.  Some devices need a little
+        * more than that, probably because of clock rate inaccuracies. */
        if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS)
-               udelay(100);
+               udelay(110);
 
        if (transfer_length) {
                unsigned int pipe = srb->sc_data_direction == DMA_FROM_DEVICE ? 



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to