On Sunday 12 December 2004 4:26 pm, Robert Wruck wrote:
> Hi,
>
> I'm encountering a strange behaviour with an AMD-756 USB controller, or
> more exactly:
> 0000:00:07.4 USB Controller: Advanced Micro Devices [AMD] AMD-756
> [Viper] USB (rev 06)
>
> There's one USB device connected at boot time (a low speed APC UPS).
> When I boot up the system and issue a 'cat /proc/bus/usb/devices', the
> process hangs and cannot be killed.
At which point an "alt-sysrq-t" traceback should be informative,
if this patch doesn't help the latest rc3-BK code.
- Dave
Don't try autosuspend if the hardware isn't known to handle it.
For example, the amd756 erratum 4 workaround needs this logic.
--- 1.49/drivers/usb/host/ohci-hub.c Sat Dec 11 06:22:07 2004
+++ edited/drivers/usb/host/ohci-hub.c Mon Dec 13 08:26:11 2004
@@ -305,7 +305,7 @@
{
struct ohci_hcd *ohci = hcd_to_ohci (hcd);
int ports, i, changed = 0, length = 1;
- int can_suspend = 1;
+ int can_suspend = hcd->can_wakeup;
unsigned long flags;
spin_lock_irqsave (&ohci->lock, flags);