On Wed, 22 Dec 2004 13:17:01 +0100, Juergen Stuber <[EMAIL PROTECTED]> wrote:
> Pete Zaitcev <[EMAIL PROTECTED]> writes: > > +out_unlocked: > > + return mbus->saved_op->submit_urb(urb, mem_flags); > > + /* Woops, we forgot to deliver success or failure to the reader */ > > +} > > you also forget to clean up when submit_urb fails, > as completion won't be called. Yes, it's true. Thank you for reminding me. At first I thought it would be harmless, but we can imagine a driver trying to resubmit a URB without refilling it and then it's going to break. I have fixed it. -- Pete ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
