On Thu, Jan 20, 2005 at 11:46:21PM +0100, Thomas Winischhofer wrote:
> Allright, version 1.0.3 of the patch attached, officially named the
> "how-to-lose-an-enthusiastic-driver-programmer-in-10-days"-edition.
Looks good, thanks for all of the fixups. See my OLS paper about kernel
coding style and why it's important that all of the code looks the same
in order for us all to get more work done.
> I hate the code as it looks now. Especially the missing "{"/"}" drive me
> crazy when it comes to consecutive if-iterations. Ugly beyond (my)
> belief, as error prone as it can be. But if you like it, be my guest ;)
Heh, the original version made my head hurt :)
Anyway, I've applied this version to my trees, and it will show up in
the next -mm release. I did have to add the following patch to fix up
some minor sparse warnings with regards to some endian issues.
thanks,
greg k-h
-----
USB: fix sparse bitwise warnings in the sisusb.c driver
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
diff -Nru a/drivers/usb/misc/sisusbvga/sisusb.c
b/drivers/usb/misc/sisusbvga/sisusb.c
--- a/drivers/usb/misc/sisusbvga/sisusb.c 2005-01-20 16:31:39 -08:00
+++ b/drivers/usb/misc/sisusbvga/sisusb.c 2005-01-20 16:31:39 -08:00
@@ -565,7 +565,7 @@
{
int ret;
int bytes_transferred = 0;
- u32 tmp;
+ __le32 tmp;
if (len == 6)
packet->data = 0;
@@ -602,7 +602,7 @@
{
int ret;
int bytes_transferred = 0;
- u32 tmp;
+ __le32 tmp;
if (len == 6)
packet->data = 0;
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
