On Fri, 21 Jan 2005, Vladimir Trukhin wrote:
> >>--- file_storage.c 2004-12-25 06:36:01.000000000 +0900
> >>+++ file_storage.c 2005-01-14 14:18:51.000000000 +0900
> >>@@ -3714,7 +3714,7 @@
> >> mod_data.protocol_type = USB_SC_SCSI;
> >> mod_data.protocol_name = "Transparent SCSI";
> >>
> >>- if (gadget_is_sh(fsg->gadget))
> >>+ if (gadget_is_sh(fsg->gadget) || gadget_is_pxa(fsg->gadget))
> >> mod_data.can_stall = 0;
> >>
> >> if (mod_data.release == 0xffff) { // Parameter wasn't set
> >>
> >>
> >
> >You don't need to do this. Just use the 'stall=no' module parameter when
> >the driver is loaded.
> >
> >
> >
>
>
> Ok, but g_file_storage accepts this parameter only in test version
> (CONFIG_USB_FILE_STORAGE_TEST).
> But what should I do if I don't use test mode?
Whoops, I forgot about that. Yes, if you don't want to use the testing
version of the driver then your patch is necessary. If someone can
confirm that this is a hardware flaw in the PXA controllers I will add
your patch into the official source.
Alan Stern
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
