On Wed, Jan 26, 2005 at 06:29:16PM +0100, Thomas Brinker wrote: > Ok, I have got it! > > The IP Packets must be aligned to 32bit on ARM. > > This patch takes care about the alignment. Please consider applying.
With this change the skb buffer would be overflowed - the size specified in the alloc_skb call above must be increased by the same number of bytes. Such alignment should be done for most architectures, not only ARM - even if unaligned memory accesses work, they can be significantly slower than properly aligned accesses. Therefore the #ifdef should be dropped. There is the NET_IP_ALIGN define in <linux/skbuff.h> for this (which can be overridden by each architecture) - it should be used instead of the hardcoded 2 constant (see the comment in the header file before it).
pgpI93P8onqur.pgp
Description: PGP signature
