On Tuesday 08 February 2005 8:38 am, Alan Stern wrote: > On Mon, 7 Feb 2005, David Brownell wrote: > > > > Print out the hardware address; match /proc/iomem. There was a patch > > submitted to make that happen, maybe it got lost somewhere. > > Okay. ohci-omap.c doesn't ever call ioremap(); it simply does > readl/writel to the resource address. Is this correct?
In this case, yes -- but odd. That resource holds the result of a static mapping for those registers, so a dynamic one isn't needed. (The sa1111 code doesn't ioremap either ...) The OMAP tree started 2.6 using direct mapping from its I/O space; the 2.4 kernel still does that. That changed about 8-10 months back to match the ARM-Linux address space convention, and incidentally making ioremap() stop being a NOP. Looks like the OHCI code didn't change at that time; and that it's the only USB driver that needs that tweak. > It leads to a > compiler warning when converting the u64 resource[0].start to (void > __iomem *) hcd->regs (cast to pointer from integer of different size). What compiler? I've never seen such a warning. Or maybe this is because of some difference in header files. Not all OMAP changes are in the main tree yet; RC3 saw a few important ones merge. > Should I stick in an intermediate cast to u32? Yes, and a FIXME for later. Thanks for catching that! - Dave ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
