On Fri, 11 Mar 2005, David Brownell wrote:

> > Which function should I schedule in the irq handler instead 
> > of (or in addition to) isp116x_hub_resume() to trigger the 
> > same sequence of resuming events like via /sys interface? Or 
> > should remote wakeup handled some other way?
> 
> See what OHCI (or maybe EHCI) does, those worked most
> recently in those scenarios.  I'd not swear they work
> quite right in 2.6.11, there's too much change in the
> relevant areas and I've not re-tested.

This is one of things that should be changed in the near future.  I'd like 
to add a resume_root_hub routine to the hcd glue layer, so that drivers 
won't need to schedule workqueue items.

> > Also, after a remote wakeup has triggered 
> > isp116x_hub_resume(), only that RH port will be operational, 
> > which got the resume signal. The other is still suspended 
> > (isp116x has got 2 ports). Should isp116x_hub_resume() 
> > resume also the other port?
> 
> It could be argued either way, I suppose, but today I'd
> argue that it shouldn't.  So long as that other port works
> correctly ... it resumes OK both through sysfs (or the
> usb resume calls, same thing) and from remote wakeup.

Of course, this is the opposite of how we handle external hubs.  We 
probably should change that too.

Alan Stern



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to