On Mon, Apr 18, 2005 at 09:49:50PM +0100, Andy Armstrong wrote: > For those who haven't seen it the Cherry CyMotion Linux keyboard is a > decent quality keyboard with the Windows specific keys replaced with > Linux keys. It's got a nice little picture of Tux on it too. The > supplied patches aren't suitable for current kernels so I've bashed > their patches into a suitable form. > > The special case in hid_get_class_descriptor() (which necessitated > moving that function after the #defines for vendor and device ID) is > lifted directly from the code Cherry supply. I'm not certain that's > the best place for it but I don't know the USB HID architecture well > enough to know what else to do with it. Suggestions welcome.
The patch looks fairly well, however, I'd prefer to replace the HID descriptor completely instead of patching it in the patch. This will allow to add fixed descriptors for other devices where the descriptors are broken. -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- This SF.Net email is sponsored by: New Crystal Reports XI. Version 11 adds new functionality designed to reduce time involved in creating, integrating, and deploying reporting solutions. Free runtime info, new features, or free trial, at: http://www.businessobjects.com/devxi/728 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
