On Thu, 14 Jul 2005, Nick Sillik wrote: > You can find attached the patch (onetouch.diff) to add functionality to > the Onetouch Button on Maxtor OneTouch external Hard Drives as well as a > kernel log of the failure(onetouch_kern_log). > > I hope a few of you remember me and my driver (and it's many, many > problems) I have been busy with other project, but have taken the time > once again to rewrite the driver. Unfortunately I got to the same point > as I did with the original driver. > > When I plug the drive in the device is recognized and everything works. > The button on the front is recognized in any keybinding software. I > unplug the drive and everything seems to go fine. When I plug the drive > back in it seems like i have a 70% chance of a complete system hang. The > other 30% the drive and button work as expected. > > If someone would be willing to give me a few pointers as to where I have > gone wrong I'd be happy to continue working on this and hopefully have > it added to the -mm tree. > > All follow-ups to this e-mail and changes to the code/patch will be > found at a url which I can post if needed, as to not spam the list with > huge attachments.
I see one big mistake. In the onetouch_release_input routine, you should not call kfree(onetouch). The main usb_storage driver automatically calls kfree(us->extra) for you, so you're double-freeing. Also, when you allocate onetouch originally, you might consider using a single call of kcalloc instead of two calling kmalloc followed by memset. Alan Stern ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
