On 8/1/05, Nick Sillik <[EMAIL PROTECTED]> wrote:
> Dmitry Torokhov wrote:
> >>+       onetouch->dev.id.bustype = BUS_USB;
> >>+       onetouch->dev.id.vendor = le16_to_cpu(udev->descriptor.idVendor);
> >>+       onetouch->dev.id.product = le16_to_cpu(udev->descriptor.idProduct);
> >>+       onetouch->dev.id.version = le16_to_cpu(udev->descriptor.bcdDevice);
> >
> > usb_to_input_id() has been merged in mainline, if the patch was not applied
> > yet can we please use it here?
> 
> Dmitry...
> 
> There was a reason I didn't do it this way... But I don't remember now.
> 
> Once it's merged, I'll try to remember. Sound good?
> 

That's fine... Although I don't think that there is a problem with
using usb_to_input_id() as it is exactly those 4 lines moved into a
function.

-- 
Dmitry


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to