On Tue, 2005-08-23 at 11:37 +0100, Richard Purdie wrote: [...] > which corrects this - I'm not sure if this is the right way to do it and > am open to comments.
Just C-specific ones - God knows what people will pass as argument: > +#ifdef CONFIG_PXA27x > +#define OHCI_GETPORTNUM(x) ((x & RH_A_NDP) + 1) +#define OHCI_GETPORTNUM(x) (((x) & RH_A_NDP) + 1) > +#else > +#define OHCI_GETPORTNUM(x) (x & RH_A_NDP) +#define OHCI_GETPORTNUM(x) ((x) & RH_A_NDP) > +#endif Bernd -- Firmix Software GmbH http://www.firmix.at/ mobil: +43 664 4416156 fax: +43 1 7890849-55 Embedded Linux Development and Services ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel