On Thu, Oct 06, 2005 at 04:50:21PM -0400, Alan Stern wrote: > Vojtech: > > This patch (as577) adds a Clear-Halt call on the Interrupt-in endpoint > during configuration. I'm not entirely sure that it's a good idea, and I > haven't been able to test it on a wide variety of devices. > > However I do have an HP keyboard that won't work without it. More > accurately, the keyboard works if the Clear-Halt is added _or_ if the call > to hid_init_reports is removed. Don't ask me why. The keyboard works > under Windows because Windows doesn't do the equivalent of > hid_init_reports. > > I don't know if this is just a weird device or if the patch might help > some others as well. You'll have to decide. > > Alan Stern
It might actually help on others. We had to do other magic dances to make them work with reading the reports or avoiding reading the reports in a blacklist. This might be a solution for all the failing devices. > > > > Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > > --- > > Index: usb-2.6/drivers/usb/input/hid-core.c > =================================================================== > --- usb-2.6.orig/drivers/usb/input/hid-core.c > +++ usb-2.6/drivers/usb/input/hid-core.c > @@ -1780,6 +1780,9 @@ static struct hid_device *usb_hid_config > hid->urbctrl->transfer_dma = hid->ctrlbuf_dma; > hid->urbctrl->transfer_flags |= (URB_NO_TRANSFER_DMA_MAP | > URB_NO_SETUP_DMA_MAP); > > + /* May be needed for some devices */ > + usb_clear_halt(hid->dev, hid->urbin->pipe); > + > return hid; > > fail: > > -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
