matthieu castet wrote:
Hi Greg,
+/*
+ * sometime hotplug don't have time to give the firmware the
+ * first time, retry it.
+ */
+static int sleepy_request_firmware(const struct firmware **fw, + const char *name, struct device *dev)
+{
+    if (request_firmware(fw, name, dev) == 0)
+        return 0;
+    msleep(1000);
+    return request_firmware(fw, name, dev);
+}



No, use the async firmware download mode instead of this.  That will
solve all of your problems.


Thanks, but does userspace will retry if it fails the first time ?
The device needs the firmware quickly and after 3-5 seconds without it, it goes berserk.

In request_firmware_nowait, when kernel_thread failed, where fw_work is freed ?
Aren't there a memleack ?

Matthieu



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to