On Wed, Nov 23, 2005 at 03:46:50PM -0200, Luiz Fernando Capitulino wrote:
> On Tue, 22 Nov 2005 14:13:53 -0800
> Greg KH <[EMAIL PROTECTED]> wrote:
>
> | On Tue, Nov 22, 2005 at 07:59:26PM -0200, Luiz Fernando Capitulino wrote:
> | > @@ -60,6 +61,7 @@ struct usb_serial_port {
> | > struct usb_serial * serial;
> | > struct tty_struct * tty;
> | > spinlock_t lock;
> | > + struct semaphore sem;
> |
> | You forgot to document what this semaphore is used for.
>
> Here goes the second patch again, with the documentation now.
>
> As I said before, would be good to apply these two patches now, and I
> can cleanup the spinlock usage until next week.
How will you clean it up?
> Fixes a race-condition in the access of the port structure, described
> in detail at:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=113216151918308&w=2
Please put the full detail in the email, so I can put it in the
ChangeLog so people have an easy place to get the proper information.
Care to redo it again?
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
