On Sat, 26 Nov 2005, Pavel Machek wrote: > Hi! > > This converts comments into C-style,
You missed a lot of them. What's the reason for this prejudice against C++-style comments in the kernel? I've never understood it... They seem so obviously useful, saving 3 characters of typing at the end of each comment line. > and removes unused > initializers. I'd like it applied... > > On a related note -- how well does it work, particulary with different > hosts? It has been quite reliable and it works with a wide variety of hosts. The main difficulties people have encountered have been related to the gadget's USB controller driver (problems with halting bulk endpoints), nothing to do with the host. > It uses 'volatile' quite heavily, and that scares me a lot. Alan Cox didn't like it either, but he wasn't able to give a clear explanation why not. He just mumbled something about C compilers generating bad code for volatiles... Probably a lot of them could be eliminated; mainly they are there to mark quantities which can be changed by interrupt handlers. I think all of the important usages are protected by a spinlock anyway. There may be a few places that aren't; IIRC none of them really matter. Alan Stern ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
