On Wed, 21 Dec 2005, Franck wrote:

> 2005/12/19, Alan Stern <[EMAIL PROTECTED]>:
> > On Mon, 19 Dec 2005, Franck wrote:
> >
> > > BTW, the hcd suspend method do:
> > >
> > >         dev->dev.power.power_state = state;
> > >
> > > I think this work should be part of the driver model, shouldn't it ?
> >
> > No.  The driver core does not understand the power states any particular
> > device can be in.  It's up to the device's driver, which does understand
> > them, to set the current power state.
> >
> 
> hmm, not sure about that, driver model does not know what peculiar
> actions must be taken for entering in any power states, but it should
> know about what a peculiar state mean...

Not so.  For example, you shouldn't expect the PM core to understand
things like D1, D2, and D3hot.  They are meaningful only for PCI devices,
anyway.

About the only thing the core might be able to understand is "fully on" 
vs. "not fully on".

> Aynways, this work seems to be already done by driver model. Check in
> "dpm_runtime_suspend" :
> 
>               if (!(error = suspend_device(dev, state)))
>                       dev->power.power_state = state;

Yes, I know.  That code does not belong there, and it will be taken out 
eventually.

Alan Stern



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to