On Fri, Jan 06, 2006 at 03:21:23PM -0800, Pete Zaitcev wrote:
> Using int for CPU flags is incorrect on x86_64.

It's incorrect everywhere, but on 64-bit architectures it really hurts.

> diff -urp -X dontdiff linux-2.4.32/drivers/usb/serial/usbserial.c 
> linux-2.4.32-wk/drivers/usb/serial/usbserial.c
> --- linux-2.4.32/drivers/usb/serial/usbserial.c       2005-04-03 
> 18:42:19.000000000 -0700
> +++ linux-2.4.32-wk/drivers/usb/serial/usbserial.c    2006-01-06 
> 14:39:37.000000000 -0800
> @@ -488,7 +524,7 @@ static void post_helper(void *arg)
>       struct usb_serial_post_job *job;
>       struct usb_serial_port *port;
>       struct usb_serial *serial;
> -     unsigned int flags;
> +     unsigned long flags;
>  
>       spin_lock_irqsave(&post_lock, flags);
>       pos = post_list.next;
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to