On Thu, 2006-01-12 at 23:33 -0800, Andrew Morton wrote:
> David Brownell <[EMAIL PROTECTED]> wrote:
> >
> > On Wednesday 11 January 2006 2:54 am, Andrew Morton wrote:
> >  > 
> >  > I'm getting bored of fixing these things.  It's someone else's turn ;)
> > 
> >  Here's a patch that should solve the net2280 one,
> 
> Danke.
> 
> > but I'm not clear why this one happens:
> 
> Because Arjan is a very bad person!

bad to the bone ;)

> 
> >  > drivers/usb/gadget/inode.c: In function `gadgetfs_fill_super':
> >  > drivers/usb/gadget/inode.c:2035: warning: passing arg 3 of 
> > `gadgetfs_make_inode' discards qualifiers from pointer target type
> > 
> >  In current GIT trees that line seems to be several lines earlier in the
> >  file, and simple_dir_operations has no qualifier.
> 
> Yes, simple_dir_operations is const in -mm.

Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]>

--- linux-2.6.15/drivers/usb/gadget/inode.c.org 2006-01-13 08:53:28.000000000 
+0100
+++ linux-2.6.15/drivers/usb/gadget/inode.c     2006-01-13 08:54:39.000000000 
+0100
@@ -1582,7 +1582,7 @@
 
 static struct inode *
 gadgetfs_create_file (struct super_block *sb, char const *name,
-               void *data, struct file_operations *fops,
+               void *data, const struct file_operations *fops,
                struct dentry **dentry_p);
 
 static int activate_ep_files (struct dev_data *dev)
@@ -1957,7 +1957,7 @@
 
 static struct inode *
 gadgetfs_make_inode (struct super_block *sb,
-               void *data, struct file_operations *fops,
+               void *data, const struct file_operations *fops,
                int mode)
 {
        struct inode *inode = new_inode (sb);
@@ -1981,7 +1981,7 @@
  */
 static struct inode *
 gadgetfs_create_file (struct super_block *sb, char const *name,
-               void *data, struct file_operations *fops,
+               void *data, const struct file_operations *fops,
                struct dentry **dentry_p)
 {
        struct dentry   *dentry;




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to