I guess I'm misunderstanding the purpose of these arbitrary limits
in usbfs. I had assumed that they weren't intended to enforce the
USB spec, but just to avoid allowing userspace processes to allocate
unreasonable amounts of unpaged memory.
--Micah
David Brownell wrote:
On Friday 27 January 2006 2:09 pm, Micah Dowty wrote:
This patch bumps usbfs' arbitrary limit on control URB buffer size
up from one page to two pages. This is necessary to support devices
that require control requests with a full 4096 bytes of data, since
the URB buffer must also include 8 bytes for the SETUP packet.
Then you should test for 4K + 8 bytes, unless you also
fix the OHCI driver to accept an 8KByte data stage...
Signed-off-by: Micah Dowty <[EMAIL PROTECTED]>
--- .pc/usbctrl-4k-limit/drivers/usb/core/devio.c 2006-01-27
14:03:54.000000000 -0800
+++ drivers/usb/core/devio.c 2006-01-27 14:03:56.000000000 -0800
@@ -872,7 +872,7 @@
!= USB_ENDPOINT_XFER_CONTROL)
return -EINVAL;
/* min 8 byte setup packet, max arbitrary */
- if (uurb->buffer_length < 8 || uurb->buffer_length > PAGE_SIZE)
+ if (uurb->buffer_length < 8 || uurb->buffer_length >
PAGE_SIZE*2)
return -EINVAL;
if (!(dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL)))
return -ENOMEM;
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
