On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote: > The following patches add drivers for the Siemens Gigaset 3070 family of > ISDN DECT PABXes connected via USB, either directly or over a DECT link > using a Gigaset M105 or compatible DECT data adapter. The devices are > integrated as ISDN adapters within the isdn4linux framework, supporting > incoming and outgoing voice and data connections, and also as tty > devices providing access to device specific AT commands.
as a general review remark: you seem to use a LOT of atomic variables. This I think is not too good an approach in general, because you get into all kinds of race situations if you need to access multiple (and you do). In addition I've seen a lot of your code using 2 or more atomics in the same function, at which point it's most likely cheaper to just have a spinlock instead... (yes a single atomic is same cost as a spinlock, but once you do multiple in the same function the price is thus higher than a spinlock ;) ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
