On Mon, 2006-03-13 at 12:46 +0000, Greg KH wrote:
> On Mon, Mar 13, 2006 at 10:17:42AM -0600, Paul Fulghum wrote:
> > Clear acm->tty on last close because the tty layer
> > releases the tty object at that point.
> 
> Does the oops go away with just this fix?

No, it is unrelated but a real bug.

> > Use a NULL device when calling tty_register_device to prevent
> > tty layer from creating sysfs entries that references the device.
> > This prevents oops in sysfs_hash_and_remove when tty_unregister_device
> > is called after usb device is disconnected during use.
> 
> This second part should not be needed, sysfs should be able to properly
> handle this.  It's just papering over a bug somewhere, and we do want
> that symlink in sysfs to be present.

This part *does* fix the oops. I just posted a revised patch
that explains it in more detail, and it turns out *not*
to by sysfs but instead is a released pointer being passed
to sysfs. 

-- 
Paul Fulghum
Microgate Systems, Ltd



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to