On Mon, 2006-03-13 at 16:43 -0500, Alan Stern wrote: > Wouldn't it be better to do get_device() on control_interface->dev just > before calling tty_register_device(), so that the data structure isn't > released too soon? (And of course, call put_device() after the tty > device is unregistered.) That way all the sysfs links remain intact, as > intended.
OK > In fact, shouldn't the tty subsystem do this automatically on behalf of > all callers? Maybe so, but it doesn't. The whole sysfs stuff is new to me, so until I did some digging I wasn't aware of how all these bits tied together. But your plan sounds reasonable (doing the get/put_device in tty_register_device). I'll put together a patch to do just that and see if Bob is still in the testing mood. -- Paul Fulghum Microgate Systems, Ltd ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
