Hi, Le Fri, 24 Mar 2006 14:32:57 -0600, Kumar Gala a écrit :
> + > +static int __init ehci_hcd_init(void) > +{ > + int retval = 0; > + > + pr_debug("%s: block sizes: qh %Zd qtd %Zd itd %Zd sitd %Zd\n", > + hcd_name, > + sizeof(struct ehci_qh), sizeof(struct ehci_qtd), > + sizeof(struct ehci_itd), sizeof(struct ehci_sitd)); > + > +#ifdef CONFIG_PPC_83xx > + retval = platform_driver_register(&ehci_fsl_dr_driver); > + if (retval < 0) > + return retval; This is wrong as the first driver could failed but the following one could be correct : imagine generic kernel were multiple config options are enabled. On some board we could have only one controller, on other both. > + retval = platform_driver_register(&ehci_fsl_dr_driver); > + if (retval < 0) > + return retval; > +#endif We should unregister all the previous drivers if we fail. Matthieu ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel