Sorry, forgot to link to the original post:
http://www.ussg.iu.edu/hypermail/linux/kernel/0603.3/1572.html
Regards,
Ole André
On 4/10/06, Ole André Vadla Ravnås <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Here's the updated patch against 2.6.16.2, which hopefully solves the
> issues that were pointed out. Except one thing:
> > You missed an update to drivers/usb/core/hub.c to the
> > configuration selection code ... it needs to know about
> > this new RNDIS variant, avoiding it if there's a standard
> > option.
>
> Not sure what to do about this as these devices only have one
> configuration, so please forgive me if I've misunderstood horribly,
> which is quite likely. :)
>
> Regards,
> Ole André
>
>
> On 4/4/06, Ole André Vadla Ravnås <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > Sorry about the late reply, work's been killing off most of my
> > spare-time lately.
> >
> > > Could you resend without line wraps etc? quoted-printable is
> > > evil for patches. Also, for my convenience in review, please
> > > pass the "p" flag to diff ("diff -Naurp") so I can see what
> > > procedures are being patched. Plus, the right place to post
> > > USB patches is [EMAIL PROTECTED] :)
> >
> > Ok, thanks, will do. I'll subscribe to that list as well and post the
> > revised patch there. :)
> >
> > > Do you have a URL for this specification? I only have the
> > > RNDIS 1.0 specification, you seem to have access to some
> > > sort of modified version ... maybe it fixes some of the holes
> > > in the 1.0 spec? Ditto the WM5 subclass and protocol ... those
> > > look like official USB-IF values, and last I checked there were
> > > no assigned values.
> >
> > Sorry, I've only got the 1.0 spec as well, I've basically
> > reverse-engineered my way to figuring out what the changes are. (Wrote
> > a quick 'n dirty app to help me comprehend the protocol:
> > http://projects.collabora.co.uk/~oleavr/usbhound.png).
> >
> > > You missed an update to drivers/usb/core/hub.c to the
> > > configuration selection code ... it needs to know about
> > > this new RNDIS variant, avoiding it if there's a standard
> > > option.
> >
> > Ah, I see. I'll fix this.
> >
> > > For rndis_host.c, please highlight that adding the extra 48
> > > bytes is a requirement MSFT added after the RNDIS 1.0 spec.
> >
> > Good point! Noted.
> >
> > > For cdc_ether.c please make
> > >
> > > /* multiline comments end like
> > > * this
> > > */
> > >
> > > instead of
> > >
> > > /* the wrong multiline comment
> > > * style */
> >
> > Noted.
> >
> > > I'm glad to see this patch. That rndis_host driver has had
> > > relatively minimal testing against MSFT code ... so it's good
> > > to see that it's getting used!
> >
> > That's good to hear. Thanks for your most excellent work! I've only
> > received positive feedback from other users with WM5 devices so far,
> > so things are looking good.
> >
> > > Hmm, well http://www.usb.org/developers/defined_class
> > > says that there is a "misc" protocol for RNDIS, but it
> > > doesn't match the one you provided (that's for Bluetooth!)
> > > and there's no spec I can find ...
> >
> > Hmm, really? I've used base class 0xEF, sub-class 0x01 and protocol
> > 0x01, which is what is specified there (if I understood it correctly).
> >
> > I'll post a revised patch as soon as I get back to life (by the end of
> > the weekend or early next week). :) Thanks a lot for your time, most
> > appreciated.
> >
> > Regards,
> > Ole André
> >
>
>
>
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
