Le mardi 18 avril 2006 à 21:25 +0900, YOSHIFUJI Hideaki / 吉藤英明 a
écrit :
> In article <[EMAIL PROTECTED]> (at Tue, 18 Apr 2006 13:07:11 +0200), Nicolas
> Boichat <[EMAIL PROTECTED]> says:
>
> > @@ -147,13 +164,22 @@ MODULE_PARM_DESC(debug, "Activate debugg
> > /* Checks if the device a Geyser 2 (ANSI, ISO, JIS) */
> > static inline int atp_is_geyser_2(struct atp *dev)
> > {
> > - int16_t productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> > + int productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> >
> > return (productId == GEYSER_ANSI_PRODUCT_ID) ||
> > (productId == GEYSER_ISO_PRODUCT_ID) ||
> > (productId == GEYSER_JIS_PRODUCT_ID);
> > }
>
> Any good reasons to change this?
Because the use of a generic integer type is generally preferred over a
fixed size type. And even if a fixed size was needed, u16/s16 would be
more appropriate.
Stelian.
--
Stelian Pop <[EMAIL PROTECTED]>
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
