Am Montag, 15. Mai 2006 14:50 schrieb Jaya Kumar:
> On 5/15/06, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> > Am Montag, 15. Mai 2006 10:49 schrieb [EMAIL PROTECTED]:
> > > +urb->status = 0;
> > > +urb->actual_length = 0;
> >
> > These are not needed. Indeed you should never write to those fields.
> >
> > Regards
> > Oliver
> >
>
> I see. Good point. I ought to have actually looked at usb_submit_urb
> and seen that it initializes status and actual_length. I'll make the
> change.
>
> To reduce my embarrassment, I'll point out that several other media
> drivers also do this:
>
> drivers/usb/media % egrep "urb->status.*=" *.c
> <snip>
> konicawc.c: urb->status = 0;
> se401.c: urb->status=0;
> stv680.c: urb->status = 0;
> usbvideo.c: urb->status = 0;
> w9968cf.c: urb->status = 0;
>
> In most of the above cases, it appears to be just before resubmitting the urb.
There's your opportunity to remove even more unnecessary kernel code.
Regards
Oliver
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
