On Sat, 20 May 2006, Greg KH wrote: > On Sat, May 20, 2006 at 10:50:22AM -0400, Alan Stern wrote: > > On Fri, 19 May 2006, Greg KH wrote: > > > > > > For this reason I am suggesting a usb_intr_msg() function which is > > > > written as usb_bulk_msg() but with usb_fill_int_urb() instead of > > > > usb_fill_bulk_urb(). > > > > > > Take a look at how usb_fill_int_urb() and usb_fill_bulk_urb() are > > > defined, they are just simple "fill up the structure" functions, and are > > > not different. > > > > That's not quite right. There is an important difference between them: > > interrupt URBs use the "interval" member. > > Yeah, but for one-show interrupt messages, it's not really a big deal :) > Relying on the endpoint interval should be sufficient.
Yes. > I have a device > here that wants this function (and for some reason I forgot all about > the bulk message working fine for interrupt messages), and I'll try it > out on Monday. > > Heh, it's the driver I use in the tutorial I give, causing a horrible > hack in the driver, I'll be glad to get rid of that.. The patch you posted is larger than it needs to be. In include/linux/usb.h, you could simply do: #define usb_intr_msg usb_bulk_msg /* One function works for both */ Alan Stern ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
