On Thu, Jun 15, 2006 at 10:14:00AM -0400, Alan Stern wrote:
> On Wed, 14 Jun 2006, Greg KH wrote:
>
> > Instead of a kobject, will make things easier in the future (don't know
> > what I was thinking when I did this originally...)
>
> That's 'cause you didn't write it originally, I did. :-)
>
> I used a kobject instead of a struct device because I didn't foresee any
> need for all the extra baggage, and I wanted to avoid uevents associated
> with the creation and removal of the endpoint objects.
Ah, you're right, I just dug through the old patches and now see that :)
> > +static void release_endpoint_class(struct kref *kref)
> > {
> > - struct ep_object *ep_obj = to_ep_object(kobj);
> > - struct ep_attribute *ep_attr = to_ep_attribute(attr);
> > + /* Ok, we cheat as we know we only have on ep_class */
>
> Typo.
Thanks, now fixed.
> > void usb_create_ep_files(struct device *parent,
> ...
> > +
> > +exit:
> > + return;
> > +error:
> > + kfree(ep_dev);
> > + goto exit;
> > }
>
> The return of spaghetti code!
I never thought it ever went away :)
thanks,
greg k-h
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
