On Mon, 19 Jun 2006 17:23:06 -0300, [EMAIL PROTECTED] wrote: > The goal is to make usb_serial_probe() smaller, clean and easy to follow.
I'd like to challenge this assertion. The diffstat is not favourable: > drivers/usb/serial/usb-serial.c | 176 > +++++++++++++++++++++++++++------------ > 1 files changed, 120 insertions(+), 56 deletions(-) The only advantage which I can see is that in-block variables and local-use variables moved into corresponding functions, thus increasing compartmentalization by a very small amount. Also, calc_num_ports was not capable of returning an error before, and it can do so now. But again, it's hard to see why it may be useful. -- Pete _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
